Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gosimple linter #23250

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add gosimple linter #23250

wants to merge 3 commits into from

Conversation

getvictor
Copy link
Member

#23249

Add gosimple linter to golangci-lint CI job.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 68.25397% with 20 lines in your changes missing coverage. Please review.

Project coverage is 63.35%. Comparing base (b67127c) to head (58e1032).

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 3 Missing ⚠️
orbit/cmd/orbit/orbit.go 0.00% 3 Missing ⚠️
cmd/cpe/generate.go 33.33% 2 Missing ⚠️
orbit/pkg/table/dataflattentable/exec.go 0.00% 2 Missing ⚠️
server/config/config.go 0.00% 0 Missing and 2 partials ⚠️
server/fleet/hosts.go 0.00% 2 Missing ⚠️
cmd/fleet/serve.go 0.00% 1 Missing ⚠️
cmd/fleet/vuln_process.go 0.00% 1 Missing ⚠️
orbit/pkg/dataflatten/flatten.go 0.00% 0 Missing and 1 partial ⚠️
orbit/pkg/execuser/execuser_linux.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23250   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files        1538     1538           
  Lines      144703   144675   -28     
  Branches     3654     3654           
=======================================
- Hits        91683    91666   -17     
+ Misses      45786    45780    -6     
+ Partials     7234     7229    -5     
Flag Coverage Δ
backend 64.25% <68.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review October 25, 2024 20:58
@getvictor getvictor requested a review from a team as a code owner October 25, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant