-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control): Mobile Ads (Banner and Interstitial) #3288
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # client/lib/main.dart # client/pubspec.lock # client/pubspec.yaml
# Conflicts: # client/pubspec.lock
Can you add (Rewarded interstitial - Interstitial Video - App Open) |
# Conflicts: # client/pubspec.lock
Reviewer's Guide by SourceryThis pull request introduces support for mobile ads (Banner and Interstitial) in the application. It includes the creation of new classes for handling different types of ads, integration of the flet_mobile_ads package into the main client application, and implementation of controls for handling these ads in Flutter. The changes ensure that the ads are properly initialized and managed within the application. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Waiting on #3345 to finalize |
.
please can you add native ads in documentation? |
I faced some issues while trying to add Native ads (forgot which one though). For a start, we will have just Banner and Interstitial ads. Native might come up later on... |
# Conflicts: # client/android/app/src/main/AndroidManifest.xml # client/lib/main.dart # client/pubspec.lock # sdk/python/packages/flet-core/src/flet_core/__init__.py
Closes #286
Test Code:
Summary by Sourcery
This pull request adds support for mobile ads (Banner and Interstitial) to the Flet framework. It includes new classes for managing these ads, updates to the main Dart file for initialization, and modifications to the pubspec.yaml to include the new package. Initial documentation for the new controls is also provided.
BannerAd
,InterstitialAd
, andNativeAd
with associated event handlers for load, error, open, close, impression, click, and will dismiss events.flet_mobile_ads
package.README.md
file of theflet_mobile_ads
package.