-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Flutter web deprecations #3932
Conversation
Reviewer's Guide by SourceryThis pull request addresses deprecation warnings in the Flutter web build process by updating the index.html file. The changes focus on replacing deprecated syntax with the recommended approach for initializing the Flutter loader and specifying the service worker version. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good job addressing the deprecation warnings. Consider investigating the remaining warning about 'serviceWorkerVersion' to see if it can be resolved in this PR as well, ensuring all deprecation issues are addressed at once.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
This PR requires more attention/work than expected :)
|
Description
Running flutter build web shows the following deprecation warning:
Right now one still appears:
flet/client/web/index.html
Lines 39 to 40 in 3260031
removing the above line clears the last deprecation warning.
@FeodorFitsner, any suggestion?
Summary by Sourcery
Remove deprecated Flutter web code by replacing 'FlutterLoader.loadEntrypoint' with 'FlutterLoader.load' and updating the service worker version handling to use the '{{flutter_service_worker_version}}' template token.
Enhancements: