-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display informative message when date
has wrong format
#4019
Conversation
Reviewer's Guide by SourceryThis pull request improves the handling of date and time inputs in the Flet library. It introduces a new utility function for datetime conversion and validation, updates the DatePicker and CupertinoDatePicker classes to use this function, and adds error handling for datetime parsing in the Control class. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Description
Closes #4017
Summary by Sourcery
Improve date and time picker components by adding validation for date values and refactoring attribute handling to enhance code clarity and robustness.
Bug Fixes:
Enhancements: