Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve adding controller nodes to e2e/local-testing setups #48

Open
invidian opened this issue Feb 18, 2020 · 3 comments
Open

Improve adding controller nodes to e2e/local-testing setups #48

invidian opened this issue Feb 18, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@invidian
Copy link
Member

There are at least 2 things, which could be improved:

  • Controller and worker IP addresses are right next to each other, so when having 1 controller and 1 worker, then adding additional controller, it's IP collides with the worker. Perhaps we should apply an offset to worker IPs by +5 or something, so max 5 controllers will be supported, which should be sufficient.
  • promoting standalone kube-apiserver to kube-apiserver with api-loadbalancer results in ports collision at the moment. Given that HAProxy footprint is really tiny, we should just always deploy it, so we are HA-ready.
@invidian invidian added the enhancement New feature or request label Feb 18, 2020
invidian added a commit to invidian/libflexkube that referenced this issue Mar 19, 2020
So there is space to add more controller nodes if needed and they won't
collide with workers or shift all addresses by one.

Part of flexkube#48

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian
Copy link
Member Author

I also got:

Error: Provider produced inconsistent final plan

When expanding the plan for flexkube_controlplane.bootstrap to include new
values learned so far during apply, provider
"registry.terraform.io/-/flexkube" produced an invalid new value for
.state[0].container[0].config[0].args[1]: was
cty.StringVal("--etcd-servers=https://192.168.51.2:2379"), but now
cty.StringVal("--etcd-servers=https://192.168.51.2:2379,https://192.168.51.3:2379").

This is a bug in the provider, which should be reported in the provider's own
issue tracker.


Error: Provider produced inconsistent final plan

When expanding the plan for flexkube_controlplane.bootstrap to include new
values learned so far during apply, provider
"registry.terraform.io/-/flexkube" produced an invalid new value for
.state[0].config_files["/etc/kubernetes/kube-apiserver/pki/apiserver.crt"]:
was
cty.StringVal("384e9fb9988342d1f5e0b89d9acdb3baec454901ab06012136948915ddd7a84f"),
but now
cty.StringVal("2051c963372e209127d11ffb0d2fede01fe7d78fadc208cc804ea24e636ecc80").

This is a bug in the provider, which should be reported in the provider's own
issue tracker.


Error: Provider produced inconsistent final plan

When expanding the plan for flexkube_controlplane.bootstrap to include new
values learned so far during apply, provider
"registry.terraform.io/-/flexkube" produced an invalid new value for
.state_sensitive: inconsistent values for sensitive attribute.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.


Error: Provider produced inconsistent final plan

When expanding the plan for flexkube_controlplane.bootstrap to include new
values learned so far during apply, provider
"registry.terraform.io/-/flexkube" produced an invalid new value for
.state_yaml: inconsistent values for sensitive attribute.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.


Error: Provider produced inconsistent final plan

When expanding the plan for flexkube_controlplane.bootstrap to include new
values learned so far during apply, provider
"registry.terraform.io/-/flexkube" produced an invalid new value for
.config_yaml: inconsistent values for sensitive attribute.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

@invidian
Copy link
Member Author

Except the error above, with upcoming fixes, adding new controller node works fine.

@invidian
Copy link
Member Author

The same errors appears when removing new controller node. But running Terraform twice fixes it.

invidian added a commit to invidian/libflexkube that referenced this issue Mar 29, 2020
When adding or removing controller node.

Refs flexkube#48

Signed-off-by: Mateusz Gozdek <[email protected]>
invidian added a commit to invidian/libflexkube that referenced this issue Mar 29, 2020
When adding or removing controller node.

Refs flexkube#48

Signed-off-by: Mateusz Gozdek <[email protected]>
invidian added a commit to invidian/libflexkube that referenced this issue Mar 30, 2020
So there is space to add more controller nodes if needed and they won't
collide with workers or shift all addresses by one.

Part of flexkube#48

Signed-off-by: Mateusz Gozdek <[email protected]>
invidian added a commit to invidian/libflexkube that referenced this issue Mar 30, 2020
So there is space to add more controller nodes if needed and they won't
collide with workers or shift all addresses by one.

Part of flexkube#48

Signed-off-by: Mateusz Gozdek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant