Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic templates & Typed Schema #1177

Merged
merged 32 commits into from
Oct 17, 2023
Merged

Dynamic templates & Typed Schema #1177

merged 32 commits into from
Oct 17, 2023

Conversation

pavjacko
Copy link
Member

@pavjacko pavjacko commented Oct 16, 2023

Description

  • migrate to fully typed schema
  • TS infer schema based getConfigProp
Screenshot 2023-10-17 at 04 36 11 Screenshot 2023-10-17 at 04 39 48

Breaking Changes

  • TBC

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@mihaiblaga89 mihaiblaga89 self-assigned this Oct 16, 2023
@pavjacko pavjacko self-assigned this Oct 16, 2023
if (runScheme) {
if (!ps.includes('-configuration')) {
p.push('-configuration');
p.push(runScheme);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This shell argument which depends on
library input
is later used in a
shell command
.
This shell argument which depends on
library input
is later used in a
shell command
.
if (runScheme) {
if (!ps.includes('-configuration')) {
p.push('-configuration');
p.push(runScheme);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This shell argument which depends on
library input
is later used in a
shell command
.
… this node exceeds the maximum length.." , add integration schema, refactor names
* main:
  1.0.0-canary.7
  fix missing android template files, added correct licenses
  fixed linting
  missing metro-config dep
  clean
  fix test
  1.0.0-canary.6
  attempt to fix plugins
  1.0.0-canary.5
  add metro-config to template
  fix/export_log
  fix/macos_build_location_info
  fix
  fix/androidwear
  fix/androidwear
  fix/web_export
  fixed test
  leftover test
@pavjacko pavjacko merged commit 60dc5df into main Oct 17, 2023
3 checks passed
@pavjacko pavjacko deleted the feat/dynamic-templates branch October 17, 2023 09:18
@pavjacko pavjacko added this to the 1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants