Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] extend platform #1191

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[feat] extend platform #1191

merged 2 commits into from
Oct 20, 2023

Conversation

pavjacko
Copy link
Member

Description

  • enables extending platform object with existing one

example:

"platforms": {
        "android": {
            "minSdkVersion": 26,
            "targetSdkVersion": 33,
            "compileSdkVersion": 33,
            "buildToolsVersion": "30.0.0",
            "gradleBuildToolsVersion": "4.2.2",
            "gradleWrapperVersion": "8.0.1",
            "kotlinVersion": "1.7.10",
            "reactNativeEngine": "hermes",
            "enableAndroidX": true,
            "templateAndroid": {
                "gradle_properties": {
                    "android.useDeprecatedNdk": true,
                    "android.enableJetifier": true,
                    "android.useAndroidX": true,
                    "android.debug.obsoleteApi": true,
                    "org.gradle.jvmargs": "-Xmx3g -XX:MaxPermSize=2048m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8",
                    "org.gradle.daemon": true,
                    "org.gradle.parallel": true,
                    "org.gradle.configureondemand": true
                },
                "MainActivity_java": {
                    "onCreate": "super.onCreate(null)"
                }
            }
        },
        "androidtv": {
            "extendPlatform": "android",
            "engine": "engine-rn-tvos"
        },
        "androidwear": {
            "extendPlatform": "android"
        },
        "firetv": {
            "extendPlatform": "android",
            "engine": "engine-rn-tvos",
            "includedPermissions": ["INTERNET"]
        }
}

Breaking Changes

  • none

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@pavjacko pavjacko merged commit e18df59 into main Oct 20, 2023
3 checks passed
@pavjacko pavjacko deleted the feat/extend-platform branch October 20, 2023 09:34
@pavjacko pavjacko added this to the 1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants