Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AndroidTV] Fix initial focus #1737

Merged
merged 4 commits into from
Oct 1, 2024
Merged

[AndroidTV] Fix initial focus #1737

merged 4 commits into from
Oct 1, 2024

Conversation

Marius456
Copy link
Contributor

Description

  • Fix initial focus for androidtv so that would focus on first button

Related issues

Npm releases

n/a

@Marius456 Marius456 added the e2e label Sep 30, 2024
@Marius456 Marius456 added this to the 1.4 milestone Sep 30, 2024
@Marius456 Marius456 self-assigned this Sep 30, 2024
@Marius456 Marius456 marked this pull request as draft September 30, 2024 07:28
GabrieleKaceviciute
GabrieleKaceviciute requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@GabrieleKaceviciute GabrieleKaceviciute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus is fixed, but it is impossible to go back to the top of page if you go down

ATV.mov

@Marius456 Marius456 added e2e and removed e2e labels Sep 30, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Sep 30, 2024
@Marius456 Marius456 marked this pull request as ready for review September 30, 2024 16:37
@Marius456 Marius456 merged commit 2dd9ad8 into main Oct 1, 2024
13 checks passed
@Marius456 Marius456 deleted the fix/andoidtv_focus_btn branch October 1, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurimasmi aurimasmi aurimasmi approved these changes

@GabrieleKaceviciute GabrieleKaceviciute GabrieleKaceviciute approved these changes

Assignees

@Marius456 Marius456

Labels
e2e
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Marius456 @aurimasmi @GabrieleKaceviciute @pauliusguzas