Feat/unified schema 2 #1743
Open
Feat/unified schema 2 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (confirm) { | ||
| const relativeShemePath = generateNewSchemaPath(configPath || ''); | ||
| if (misNamespace) { | ||
| delete updatedConfigFile[misNamespace].$schema; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
locksten
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Lightning and windows engines have missing renative.engine.json properties.
After migrating, my renative.local.json has double local, which is probably incorrect:
{
"local": {
"_meta": {
"currentAppConfigId": "harness"
}
},
"project": {},
"_meta": {
"currentAppConfigId": "harness"
}
}
{
"local": {
"local": {
"_meta": {
"currentAppConfigId": "harness"
}
},
"project": {},
"_meta": {
"currentAppConfigId": "harness"
}
},
"$schema": ".rnv/schema/renative-1.0.schema.json"
}| @@ -79,7 +81,7 @@ describe('taskCryptoEncrypt tests', () => { | |||
| //GIVEN | |||
| const ctx = getContext(); | |||
| ctx.files.project.config = { | |||
| projectName: '@rnv/testProject', | |||
| project: { projectName: '@rnv/testProject' }, | |||
There was a problem hiding this comment.
There seem to be missing properties here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Npm releases
n/a