Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change tizen certificate command in new project #1758

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix change tizen certificate command in new project #1758

merged 1 commit into from
Oct 18, 2024

Conversation

Marius456
Copy link
Contributor

@Marius456 Marius456 commented Oct 17, 2024 •
edited
Loading

Description

Fix change tizen certificate in new project

To test it:

  • in monorepo run yarn watch
  • create new project
  • rnv link
  • run npx rnv tizen certificate
  • follow instructions

Related issues

Npm releases

n/a

@Marius456 Marius456 added the e2e label Oct 17, 2024
@Marius456 Marius456 added this to the 1.4 milestone Oct 17, 2024
@Marius456 Marius456 self-assigned this Oct 17, 2024
@Marius456 Marius456 changed the title fix change cert in new project Fix change tizen certificate command in new project Oct 17, 2024
@pauliusguzas pauliusguzas self-requested a review October 17, 2024 13:58
pauliusguzas
pauliusguzas requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with linked template and getting same error

@Marius456
Copy link
Contributor Author

tested with linked template and getting same error

Can you give steps that you did? Did you use rnv link?

@pauliusguzas pauliusguzas self-requested a review October 17, 2024 15:56
pauliusguzas
pauliusguzas approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, forgot to do rnv link, works now

@locksten locksten self-requested a review October 18, 2024 07:05
@Marius456 Marius456 merged commit 42dea49 into release/1.4 Oct 18, 2024
10 of 11 checks passed
@Marius456 Marius456 deleted the fix/generate_cert_tizen branch October 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locksten locksten locksten approved these changes

@pauliusguzas pauliusguzas pauliusguzas approved these changes

Assignees

@Marius456 Marius456

Labels
e2e
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Marius456 @locksten @pauliusguzas