Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added plain stream() method #575

Merged
merged 2 commits into from
Apr 13, 2024
Merged

added plain stream() method #575

merged 2 commits into from
Apr 13, 2024

Conversation

n0nag0n
Copy link
Collaborator

@n0nag0n n0nag0n commented Apr 12, 2024

Simplified streaming methods with stream() route method

@fadrian06
Copy link
Contributor

In a while I'll run the tests just in case hehe, right now I don't have electricity

@fadrian06 fadrian06 self-requested a review April 12, 2024 23:45
@fadrian06
Copy link
Contributor

PHPUnit 9.6.18 by Sebastian Bergmann and contributors.

Runtime: PHP 7.4.33
Configuration: C:\xampp\htdocs\libs\flight\phpunit.xml
Random Seed: 1712965480

............................................................... 63 / 288 ( 21%)
.................................................F

Time: 00:01.854, Memory: 10.00 MB

There was 1 failure:

  1. tests\ResponseTest::testResponseBodyCallbackGzip
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'H4sIAAAAAAAAAytJLS4BAAx+f9gEAAAA'
    +'H4sIAAAAAAAACitJLS4BAAx+f9gEAAAA'

C:\xampp\htdocs\libs\flight\tests\ResponseTest.php:285
phpvfscomposer://C:\xampp\htdocs\libs\flight\vendor\phpunit\phpunit\phpunit:106
C:\xampp\htdocs\libs\flight\vendor\bin\phpunit:118

FAILURES!
Tests: 113, Assertions: 206, Failures: 1.

@fadrian06
Copy link
Contributor

PHPUnit 9.6.18 by Sebastian Bergmann and contributors.

Runtime: PHP 8.2.17
Configuration: C:\xampp\htdocs\libs\flight\phpunit.xml
Random Seed: 1712965580

............................................................... 63 / 288 ( 21%)
......................................F

Time: 00:00.733, Memory: 8.00 MB

There was 1 failure:

  1. tests\ResponseTest::testResponseBodyCallbackGzip
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'H4sIAAAAAAAAAytJLS4BAAx+f9gEAAAA'
    +'H4sIAAAAAAAACitJLS4BAAx+f9gEAAAA'

C:\xampp\htdocs\libs\flight\tests\ResponseTest.php:285
C:\xampp\htdocs\libs\flight\vendor\bin\phpunit:122

FAILURES!
Tests: 102, Assertions: 152, Failures: 1.

Copy link
Contributor

@fadrian06 fadrian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test fail on my machine

@n0nag0n
Copy link
Collaborator Author

n0nag0n commented Apr 13, 2024

Huh, I wonder if that's a difference between windows vs linux implementation of gzip? Just double check and run composer update On your recent PR I had an error in PHPStan and I couldn't make it go away until I updated (not realizing it was out of date), and updated whatever packages you have for php/gzip. Just in case they are out of date. It's really weird it's only mixing up two characters in the middle.

@fadrian06
Copy link
Contributor

I guess I'll make an assert for windows and another for unix xD

@fadrian06
Copy link
Contributor

I'm checking phpstan right now

@fadrian06
Copy link
Contributor

image
image
image

@fadrian06 fadrian06 merged commit 17002a6 into master Apr 13, 2024
@fadrian06 fadrian06 deleted the stream-tweaks branch April 13, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants