-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added plain stream() method #575
Conversation
In a while I'll run the tests just in case hehe, right now I don't have electricity |
PHPUnit 9.6.18 by Sebastian Bergmann and contributors. Runtime: PHP 7.4.33 ............................................................... 63 / 288 ( 21%) Time: 00:01.854, Memory: 10.00 MB There was 1 failure:
C:\xampp\htdocs\libs\flight\tests\ResponseTest.php:285 FAILURES! |
PHPUnit 9.6.18 by Sebastian Bergmann and contributors. Runtime: PHP 8.2.17 ............................................................... 63 / 288 ( 21%) Time: 00:00.733, Memory: 8.00 MB There was 1 failure:
C:\xampp\htdocs\libs\flight\tests\ResponseTest.php:285 FAILURES! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a test fail on my machine
Huh, I wonder if that's a difference between windows vs linux implementation of gzip? Just double check and run |
I guess I'll make an assert for windows and another for unix xD |
I'm checking phpstan right now |
Simplified streaming methods with
stream()
route method