Fix for Issue 209: Undefined method 'type' for nil:NilClass #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Feb 8, 2024
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module Deimos | |||
| VERSION = '1.23.3' | |||
| VERSION = '1.23.4' | |||
There was a problem hiding this comment.
Please don't bump the version as part of the PR - we can do that separately.
| @@ -29,6 +29,9 @@ def coerce_union(type, val) | |||
| def coerce_record(type, val) | |||
| record = val.map do |name, value| | |||
| field = type.fields.find { |f| f.name == name } | |||
|
|
|||
| raise "Field #{name} does not exist in Avro::Schema" if field.nil? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Issue 209: Undefined method 'type' for nil:NilClass
This error occurs when record key doesn't exist in the actual schema.
Seems that in old versions such gaps would let it pass, but newer versions have more validation and it starts failing with this error which makes it being not backward compatible and difficult to debug.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
for the following schema.
As it appeared the schema was way outdated and the issue was fixed by updating schema.
This fix is for a proper error handling which should ease the debugging when this kind of situation happen.
Checklist: