Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser for Santiago, Chile BIP transit card #3456

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Parser for Santiago, Chile BIP transit card #3456

merged 6 commits into from
Mar 4, 2024

Conversation

rbasoalto
Copy link
Contributor

@rbasoalto rbasoalto commented Feb 16, 2024 •
edited by gornekich
Loading

What's new

  • Parser for Bip Card (Santiago, Chile public transit)

Verification

  • Try it with any of these saved cards (old dumps of some cards that I got permission to share, converted to Flipper NFC file format)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Parser for Santiago, Chile BIP transit card
d6141fa 
It's used for all public transportation in the city of Santiago, Chile
(bus, subway). We've reverse-engineered most of the non-zero bits of
data found, and checked them across dozens of cards.
@skotopes skotopes added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels Feb 17, 2024
gornekich
gornekich requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rbasoalto , thanks a lot for PR!

I tested and everything works fine. Please make some changes and we will merge your PR.

applications/main/nfc/plugins/supported_cards/bip.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/bip.c Outdated Show resolved Hide resolved
gornekich
gornekich approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@skotopes skotopes merged commit 1070064 into flipperdevices:dev Mar 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees

@gornekich gornekich

Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbasoalto @gornekich @skotopes