[FL-3890] Infrared button operation fails now shows more informative messages #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebornedBrain
changed the title
…for the button index
RebornedBrain
requested review from
skotopes,
DrZlo13,
hedger and
gsurkov
as code owners
skotopes
approved these changes
Sep 6, 2024
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
…messages (flipperdevices#3859) * Error codes enum added * Adjusted signal api to return error codes instead of bool * Remote api adjusted to work with error codes * Brute force logic adjusted to work with error codes * Other application functions adjust to work with error codes * All task callbacks now return ErrorCode through int32t, which belongs to thread * All scenes now work with error codes * More api functions now return error code * Now signal names are buffered and restored in case of error. * New error code enumeration added. Now least significant byte is left for the button index * Some macro to simplify error setup and error check * Error code checks replaced by macro * Different message is now shown when move failed * Comments updated * Fixed error check * Fixed navigation issue while openning broken files from Favorites * Now search by index also returns index in addition to error code * Remote loading logic adjusted * New error codes added and numbers adjusted * New error message when loading library file instead of signal one * Some more remote loading logic adjusted * New error message on rename fail * Grammar mistake fix * Function signature changed * Function usage adjusted according to new signature Co-authored-by: あく <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Related issue: #3845
Verification
Open .ir file with raw signals, where one signal has more than 1024 samples
Try to delete ANY button. Result: such message with name of a bad signal will be displayed
File remains unchanged and no .swp files will be present on the sd card.
Try to move ANY button. Result: such message with name of a bad signal will be displayed
File remains unchanged and no .swp files will be present on the sd card.
Try to rename ANY button. Result:* such message with name of a bad signal will be displayed
File remains unchanged and no .swp files will be present on the sd card.
Open .ir file with raw signals, where one signal has more than 1024 samples from Favorites or Browser. Try to delete, move, rename any signal, it will show same error message. Previously after pressing "Back" a screen with sandwatch was shown and flipper stucked on it, now it will move back to the remote scene.
Regarding issue #3845
Checklist (For Reviewer)