Implements goto prev/next page feature

[isundaylee]

For now I implemented a very naive algorithm that looks for with
matching text. It would probably be better to somehow reuse the logic in
the hint link discovery, but it is actually subtly different here. In
hint link discovery, we do a DFS from the root document, and stop
recursing whenever we identify a link. But here we actually want to
visit every child, since the text could potentially be on one of the
child elements instead.

Text matching patterns for next/previous page links can be configured as
nextpagetextpatterns and prevpagetextpatterns options in sVimrc.

Default settings tested on Google, and GitHub issue page.

[abrookins]

Hi, Jiahao! Thanks much for your PR. I will review soon -- this is a feature I've wanted from sVim for a long time. :)

[abrookins]

@isundaylee Thanks so much for your time writing up this PR! I think the direction I'd like to see the next/previous button go is more along the lines of how cvim does it: https://github.com/1995eaton/chromium-vim/blob/fe60f5fa18e5f6ec379494c346127a221307aff7/content_scripts/hints.js#L27

If you look at how Hints.matchPatterns works over there (it's MIT-licensed, so feel free to use whatever code you want -- if you're interested in continuing to work on this feature!), you'll see that cvim cheats a bit in a good way. That is, the plugin stores a few CSS targets for commonly-used sites, and tries to match one to the current URL first. Only then, when it can't find a match, does is compile a regex object and search the available links on the page. Something like that would be best.

[isundaylee]

Thanks for the direction suggestion! I’ll take a look at that and revise :)

…

On Wed, 5 Sep 2018 at 18:45, Andrew Brookins ***@***.***> wrote: @isundaylee <https://github.com/isundaylee> Thanks so much for your time writing up this PR! I think the direction I'd like to see the next/previous button go is more along the lines of how cvim does it: https://github.com/1995eaton/chromium-vim/blob/fe60f5fa18e5f6ec379494c346127a221307aff7/content_scripts/hints.js#L27 If you look at how Hints.matchPatterns works over there (it's MIT-licensed, so feel free to use whatever code you want), you'll see that cvim cheats a bit in a good way. That is, the plugin stores a few CSS targets for commonly-used sites, and tries to match one to the current URL first. Only then, when it can't find a match, does is compile a regex object and search the available links on the page. Something like that would be best. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf__dCq6yaKvYxJpd6T5QrMivOthIjMks5uYFPugaJpZM4WMkbB> .

[abrookins]

I'm going to merge this as-is so we get this feature into the 1.0.7 release, and we (or you, if you're interested!) can iterate on it if needed. Also, thanks so much for looking into this feature! It was #1 on my list of things I wished sVim did.