fix(ui): remove unnecessary scrolls for quick edit forms (#3592)

Signed-off-by: Roman Dmytrenko <[email protected]>
flipt-io · Nov 5, 2024 · b1c92b3 · b1c92b3
1 parent b493c3b
commit b1c92b3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/ui/src/app/flags/rules/Rules.tsx b/ui/src/app/flags/rules/Rules.tsx
@@ -145,7 +145,7 @@ export function DefaultVariant(props: RulesProps) {
               </div>
               <div className="flex w-full flex-1 items-center p-2 text-xs lg:p-0">
                 <div className="flex grow flex-col items-center justify-center sm:ml-2 md:flex-row md:justify-between">
-                  <Form className="bg-white flex w-full flex-col overflow-y-scroll">
+                  <Form className="bg-white flex w-full flex-col">
                     <div className="w-full flex-1">
                       <div className="space-y-6 py-6 sm:space-y-0 sm:py-0">
                         {flag.variants && flag.variants.length > 0 && (

diff --git a/ui/src/components/rollouts/Rollouts.tsx b/ui/src/components/rollouts/Rollouts.tsx
@@ -118,7 +118,7 @@ export function DefaultRollout(props: RolloutsProps) {
 
               <div className="flex w-full flex-1 items-center p-2 text-xs lg:p-0">
                 <div className="flex grow flex-col items-center justify-center sm:ml-2 md:flex-row md:justify-between">
-                  <Form className="bg-white flex w-full flex-col overflow-y-scroll">
+                  <Form className="bg-white flex w-full flex-col">
                     <div className="w-full flex-1">
                       <div className="space-y-6 py-6 sm:space-y-0 sm:py-0">
                         <div className="space-y-1 px-4 sm:grid sm:grid-cols-3 sm:gap-4 sm:space-y-0 sm:p-2">

diff --git a/ui/src/components/rollouts/forms/QuickEditRolloutForm.tsx b/ui/src/components/rollouts/forms/QuickEditRolloutForm.tsx
@@ -155,7 +155,7 @@ export default function QuickEditRolloutForm(props: QuickEditRolloutFormProps) {
       }}
     >
       {(formik) => (
-        <Form className="bg-white flex h-full w-full flex-col overflow-y-scroll">
+        <Form className="bg-white flex h-full w-full flex-col">
           <div className="w-full flex-1">
             <div className="space-y-6 py-6 sm:space-y-0 sm:py-0">
               {rollout.type === RolloutType.THRESHOLD ? (

diff --git a/ui/src/components/rules/forms/QuickEditRuleForm.tsx b/ui/src/components/rules/forms/QuickEditRuleForm.tsx
@@ -195,7 +195,7 @@ export default function QuickEditRuleForm(props: QuickEditRuleFormProps) {
     >
       {(formik) => {
         return (
-          <Form className="bg-white flex h-full w-full flex-col overflow-y-scroll">
+          <Form className="bg-white flex h-full w-full flex-col">
             <div className="w-full flex-1">
               <div className="space-y-6 py-6 sm:space-y-0 sm:py-0">
                 <div className="space-y-1 px-4 sm:grid sm:grid-cols-3 sm:gap-4 sm:space-y-0 sm:px-6 sm:py-2">