-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): save sort state in redux #3415
Conversation
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
=======================================
Coverage 64.65% 64.65%
=======================================
Files 174 174
Lines 13907 13907
=======================================
Hits 8992 8992
Misses 4227 4227
Partials 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We need to change API to pass the order param because of pagination. |
How do you mean? The pagination still happens client side as well |
Client fetches the limited number of flags/segments, right? If backend has no knowledge of ordering that may lead to unexpected results if I don't miss something. |
My bad... it looks like client fetches all the flags at once. I looked at tests where limit is set |
Yeah we would eventually like to move pagination/sorting/etc to server side (call the API) but this has implications with the search box that pops up if you have more than 15 flags (I think). Currently search is done client side too, which it can do because it pulls down all flags at once. If we moved to server side pagination we would have to come up with a different solution for search, like an API endpoint |
Signed-off-by: Mark Phelps <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Signed-off-by: Mark Phelps <[email protected]>
* 'main' of https://github.com/flipt-io/flipt: feat(ui): save sort state in redux (#3415) fix(authz): added a helper function to the policy engine to simplify (#3419) chore: upgrade formbricks lib; reword banner and onboarding (#3414)
Re: #3413
Moves sorting state of tables to redux so that it persists between pages
TODO
Anywhere else we allow sorting in tableswill do this if requested by users later