Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip authz for clickhouse #3511

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

markphelps
Copy link
Collaborator

Fixes: #3510

@markphelps markphelps marked this pull request as ready for review September 30, 2024 21:35
@markphelps markphelps requested a review from a team as a code owner September 30, 2024 21:35
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.75%. Comparing base (392a48a) to head (4db5a5d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
+ Coverage   64.68%   65.75%   +1.07%     
==========================================
  Files         174      169       -5     
  Lines       13930    13629     -301     
==========================================
- Hits         9010     8962      -48     
+ Misses       4231     3982     -249     
+ Partials      689      685       -4     
Flag Coverage Δ
unittests 65.75% <100.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Oct 1, 2024
@kodiakhq kodiakhq bot merged commit 490cc12 into main Oct 1, 2024
63 checks passed
@kodiakhq kodiakhq bot deleted the skip-authz-analytics-server branch October 1, 2024 11:22
markphelps added a commit that referenced this pull request Oct 1, 2024
…o gm/flipt-edge

* 'gm/flipt-edge' of https://github.com/flipt-io/flipt:
  docs: add devumesh as a contributor for code (#3512)
  feat(ext): determinism in exporting and declarative formats (#3509)
  fix: skip authz for clickhouse (#3511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Analytics Service: Request Must Implement flipt.Requester
2 participants