Leave hot signer unlocked after adding account #1339
Conversation
goosewobbler
changed the title
…ose the signer afterAll if not done yet
| expect(signer.id).not.toBe(undefined) | ||
| expect(store(`main.signers.${signer.id}.id`)).toBe(signer.id) | ||
| done() | ||
| }) | ||
| } catch (e) { | ||
| done(e) | ||
| } | ||
| }, 2000) | ||
| }, 10_000) |
There was a problem hiding this comment.
@mholtzman looks like the tests failed because this test timed out, which then lead to the signer not being assigned. I have set a longer timeout here as this prevents similar failures
There was a problem hiding this comment.
is this happening locally or only in CI? I think this was an already existing problem in our Github actions flow so we should probably just fix the tests at some point to prevent these flaky failures
There was a problem hiding this comment.
Yup, only in the CI
| @@ -43,7 +43,9 @@ describe('Ring signer', () => { | |||
|
|
|||
| afterAll(() => { | |||
| clean() | |||
|
|
|||
| if (signer.status !== 'locked') { | |||
There was a problem hiding this comment.
after all the tests are run we should know what state the signer is in. what's this check for?
There was a problem hiding this comment.
This is in case there is an unfortunate failure in one of the test cases, I was thinking that this would precent the really long hanging build (looks like last one hung for ~6hrs?
| expect(signer.addresses.length).toBe(100) | ||
| expect(store(`main.signers.${signer.id}.id`)).toBe(signer.id) | ||
| done() | ||
| }) | ||
| } catch (e) { | ||
| done(e) | ||
| } | ||
| }, 7_500) |
There was a problem hiding this comment.
is there a specific change we made that is causing these tests to take so long?
There was a problem hiding this comment.
It is because the unlock is now taking place in the same function call as the creation as far as I can tell
No description provided.