Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade trezor #1342

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Upgrade trezor #1342

merged 3 commits into from
Jan 13, 2023

Conversation

mholtzman
Copy link
Collaborator

@mholtzman mholtzman commented Jan 13, 2023 •
edited
Loading

this seems to just work without any code changes.

tested:

  • connecting while Frame is running (both T1 and Trezor T)
  • connecting on startup (both)
  • disconnect/reconnect while Frame is running (both)
  • enter pin (T1)
  • enter passphrase on device (T)
  • enter passphrase in Frame (both)
  • switch derivation between legacy, standard, testnet (both)
  • send transaction on testnet (both)
  • sign eth message and personal message (both)
  • sign typed data v4 (both)

@goosewobbler goosewobbler added the dependencies Pull requests that update a dependency file label Jan 13, 2023
goosewobbler
goosewobbler reviewed Jan 13, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@mholtzman mholtzman merged commit d6daf69 into develop Jan 13, 2023
@mholtzman mholtzman deleted the upgrade-trezor branch January 13, 2023 19:24
@goosewobbler goosewobbler mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goosewobbler goosewobbler goosewobbler approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file hardware signers trezor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mholtzman @goosewobbler