Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update approval summary to show unlimited approvals #1400

Merged
merged 2 commits into from
Feb 10, 2023
Merged

update approval summary to show unlimited approvals #1400

merged 2 commits into from
Feb 10, 2023

Conversation

mholtzman
Copy link
Collaborator

@mholtzman mholtzman commented Feb 2, 2023 •
edited
Loading

image

@Jamchello
Copy link
Contributor

Do we want the approximation '~' here before unlimited?

@mholtzman
Copy link
Collaborator Author

Do we want the approximation '~' here before unlimited?

I think it works a little better without it here as this is the section that shows a natural language overview

@Jamchello
Copy link
Contributor

LGTM

@mholtzman mholtzman merged commit 13e334d into develop Feb 10, 2023
@mholtzman mholtzman deleted the show-unlimited-approval branch February 10, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamchello Jamchello Jamchello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mholtzman @Jamchello