Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize transaction chain id to handle non-standard chain ids and r… #1411

Merged
merged 4 commits into from
Feb 14, 2023
Merged

normalize transaction chain id to handle non-standard chain ids and r… #1411

merged 4 commits into from
Feb 14, 2023

Conversation

mholtzman
Copy link
Collaborator

…espond with proper errors

goosewobbler
goosewobbler reviewed Feb 14, 2023
View reviewed changes
main/api/ws.ts Outdated Show resolved Hide resolved
goosewobbler
goosewobbler reviewed Feb 14, 2023
View reviewed changes
main/api/http.ts Outdated Show resolved Hide resolved
goosewobbler
goosewobbler previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@goosewobbler goosewobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but LGTM otherwise

@mholtzman
Copy link
Collaborator Author

Couple of nits but LGTM otherwise

fixed

@goosewobbler goosewobbler merged commit 07f9e0d into develop Feb 14, 2023
@goosewobbler goosewobbler deleted the tx-chains branch February 14, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goosewobbler goosewobbler goosewobbler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mholtzman @goosewobbler