Linting fixes

[goosewobbler]

Addressing all low-hanging fruit linting issues - config in #1337

Note we are not addressing warnings at the moment - there are a lot of any types which we absolutely should replace as our use of TS in Frame expands and improves, but addressing this now requires a fair bit of work and also high levels of risk due to the amount of refactoring involved.

Remaining issues to address before we can enforce linting, we can do this here or with follow-up PR(s):

• react-hooks/rules-of-hooks - React Hook "useCountdown" is called conditionally. React Hooks must be called in the exact same order in every component render

  • frame/resources/Components/Countdown/index.js

    Line 4 in 52d751e

    const ttl = isFinite(new Date(end)) ? useCountdown(end) : 'INVALID DATE'

• @typescript-eslint/ban-types - Don't use {} as a type. {} actually means "any non-nullish value".

  • frame/main/transaction/actions/index.ts

    Line 11 in 52d751e

    update?: (request: AccountRequest, params: Partial<T>) => {}

  • frame/main/externalData/coingecko/index.ts

    Line 25 in 52d751e

    platforms?: {}

• @typescript-eslint/ban-types - Don't use Function as a type. The Function type accepts any function-like value.

  • frame/main/externalData/balances/index.ts

    Line 44 in 52d751e

    let onResume: Function | null

• @typescript-eslint/ban-ts-comment - Do not use "@ts-ignore" because it alters compilation errors

  • frame/main/nebula/index.ts

    Line 5 in 52d751e

    // @ts-ignore

  • frame/main/nebula/index.ts

    Line 10 in 52d751e

    // @ts-ignore

• no-async-promise-executor - Promise executor functions should not be async

  • frame/main/externalData/inventory/tokens.ts

    Line 48 in 52d751e

    return new Promise<TokenSpec[]>(async (resolve, reject) => {

• @typescript-eslint/no-empty-function - Unexpected empty method '_read' -

  • frame/main/dapps/index.ts

    Line 27 in 52d751e

    _read() {}

• no-undef:
  • 'task' is not defined -

    frame/hardhat.config.js

    Line 5 in 52d751e

    return task(taskName, taskDescription)

  • 'chain' is not defined -

    frame/app/tray/Footer/index.js

    Line 113 in 52d751e

    link.send('tray:switchChain', chain.type, parseInt(chain.id), req)

  • 'chain' is not defined -

    frame/app/tray/Footer/index.js

    Line 113 in 52d751e

    link.send('tray:switchChain', chain.type, parseInt(chain.id), req)

  • 'Buffer' is not defined -

    frame/app/tray/Account/Requests/SignatureRequest/index.js

    Line 8 in 52d751e

    const buff = Buffer.from(stripHexPrefix(rawMessage), 'hex')

  • 'require' is not defined -

    frame/app/dash/Main/index.js

    Line 25 in 52d751e

    const appVersion = require('../../../package.json').version

• react/no-find-dom-node - Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode

  • frame/app/tray/AccountSelector/index.js

    Line 32 in 52d751e

    this.store.initialScrollPos(ReactDOM.findDOMNode(this.scroll).scrollTop)

  • frame/app/tray/Account/index.js

    Line 18 in 52d751e

    this.store.initialScrollPos(ReactDOM.findDOMNode(this.scroll).scrollTop)

• no-empty - Empty block statement

  • frame/app/dash/Chains/Chain/ChainNew/index.js

    Line 37 in 52d751e

    } catch (e) {}

• react/no-direct-mutation-state - Do not mutate state directly. Use setState()

  • frame/app/tray/Account/Requests/TransactionRequest/AdjustFee/index.js

    Line 271 in 52d751e

    this.state[name] = value

  • frame/app/dash/Accounts/Add/AddHardwareLattice/index.js

    Line 70 in 52d751e

    this.setState({ index: ++this.state.index })

[mholtzman]

looks good, just a couple comments. also I'm getting some TS compilation errors on this branch, do I need to change anything?

[goosewobbler]

@mholtzman did you do a setup:clean? Maybe you didn't install the deep-equal types