Fix Luxembourg phone numbers #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Luxembourg rules to match actual phone numbers
|
Tested with the numbers that I had troubles with, and works like a charm 👍 |
|
What a nice PR. Thanks so much! ☀️ Also loving the collaboration going on here. |
|
Released as 2.15.17. |
|
It took months, but it's finally tested and merged ! Thanks guys ! 👍 |
|
@jdel Thank you! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported our application not accepting his phone number and when I saw #276 so I decided to complete the work started by @jdel 😄
I had to add a fallback match for the
it_splits '35227855', ['352', '27', '85', '5']test case to pass. I'm no expert on Luxembourg numbers either but the changes to the existing tests don't seem too invasive.