Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ListBoxHeader/Footer to Begin/EndListBox for imgui 1.89.6 #83

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Mokona
Copy link
Contributor

@Mokona Mokona commented Jul 10, 2023

imgui 1.89.6 removed the ListBoxHeader and ListBoxFooter functions.

imgui 1.89.6 removed the ListBoxHeader and ListBoxFooter functions.
@floooh
Copy link
Owner

floooh commented Jul 11, 2023

Thanks for the PR! I'll need to sync the merge with updating the fips-imgui dependencies here though, so I can't merge immediately:

https://github.com/fips-libs/fips-imgui

@Mokona
Copy link
Contributor Author

Mokona commented Jul 12, 2023

I checked the time of addition of BeginListBox(). This new function has been added in March 2021 for version 1.81.

The existence of previous function ListBoxHeader() was kept for easy deprecation change.

I've cloned a new depot with chips and chips-test and this PR change, without touching the references fips-imgui, and it seems to work, unless I missed a step (my test was not pushed more than that though, I'd stay cautious).

@floooh
Copy link
Owner

floooh commented Jul 12, 2023

Ah right... thanks for the info :) In that case I guess I can merge (I'll wait for the CI pipeline to finish)

@floooh floooh merged commit a59dd2a into floooh:master Jul 12, 2023
8 checks passed
@floooh
Copy link
Owner

floooh commented Jul 12, 2023

...and merged, many thanks!

(I wonder why I haven't started the CI checks yesterday, because then it would be obvious that it works with Dear ImGui 1.89.5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants