-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jai bindgen #1090
Add Jai bindgen #1090
Conversation
957275c
to
5696bcf
Compare
5696bcf
to
f146fc1
Compare
One thing we need to fix before the merge is to allow the Github Action script which automatically updates the bindings push access to the sokol-jai repository, and for that I'll need your help to add a 'deploy key' to your repository. We already did the same thing before with the sokol-d bindings repository which is also not owned by me: https://github.com/kassane/sokol-d. The process is as follows:
Alternatively I can also fork your sokol-jai repo and manage everything on my side, this would however mean that the 'official' Jai bindings would be under https://github.com/floooh/sokol-jai (I would prefer though to keep it under your location because 'credit where credit is due' ;) In any case here's the public key I created:
...the result should then look similar to this: ...on my side I will add the private key as CI secret, accessible from the gen_bindings.yml script. Thanks! |
PS: the failing CI pipeline is expected. No need to fix anything on your side. |
I've added the deploy key, let me know if you run into any issues. |
Thanks! I'll try to look into the rest tomorrow evening (if nothing higher priority comes inbetween). |
Ok, looking into this now. I'll add GH Actions integration in my own merge branch... |
...I don't run actual compile tests in the ...at one point we'd want to add a CI pipeline to the sokol-jai repo which runs on new commits, like this: https://github.com/floooh/sokol-zig/blob/master/.github/workflows/main.yml ...then I can also add a badge for the Jai bindings to the sokol readme... |
Ok, I'm going to merge now. There's a slight chance that the CI pipeline which then starts will mess up your sokol-jai repository (worst thing that can happen is that I messed up the subpath and there will be files committed to the wrong place). Since the sokol-jai repo is already on a recent version I'm actually expecting that no commit is created, but we'll see... |
...ok let's see what happens: https://github.com/floooh/sokol/actions/runs/10391639556 |
Hmm, yeah, no changes and thus nothing committed: https://github.com/floooh/sokol/actions/runs/10391639556/job/28775312222
|
...I think I'll do a little whitespace commit to one of the sokol headers to test if the access-token stuff works... |
Ok it seems to work, when you look in: https://github.com/colinbellino/sokol-jai There's now an automatic commit (just a whitespace change in sokol_audio.h) ...I'll update the sokol readme and changelog, and that should be it. Many thanks for the PR! |
Oh yeah, i guess there is no real way to compile in GH CI since the repository is public. 🤔 |
Thank you for taking the time to look into this and merging it @floooh ! |
See floooh#1090 Many thanks to @kochol for noticing the issue.
I've created
gen_jai.py
to support generating Jai bindings, based on the work done ingen_odin.py
.Note: right now
gen_all.py
expects asokol-jai/
folder to be present so i've added a line to the README with the bindings i'm maintaining here, feel free to delete that commit.