Correct order of mouse/tap events to ImGui for correct touch event handling #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! I wasn't aware that the calling order matters so much with the new evented input API. The PR looks simple enough, I'll just merge it 'blindly', and then update the samples webpage. |
|
Ok, the samples webpage has been updated, and the UI works great on my Android phone! |
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mouse worked fine, because mouse movement events were updated along the way, but touch events do not do that, so imgui was processing button pushes at the previous tap's location resulting in several issues including getting stuck int he dragging window state like this:
screen-20221213-130231.mp4
This PR fixes that issue, and likely fixes issues with selecting buttons rapidly with a mouse (for example a macro that teleports the mouse and doesnt generate move events... I don't know if that is likely to happen or not).