Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote points to avoid issues with reserved words #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quote points to avoid issues with reserved words #5

wants to merge 1 commit into from

Conversation

jfrioux
Copy link
Contributor

@jfrioux jfrioux commented Dec 3, 2020

Ref: floraison/flor#36

Also added a note about that in the README.

@jmettraux
Copy link
Member

Sorry, is the change linked to floraison/flor#36 not fixing this issue?

@jfrioux
Copy link
Contributor Author

jfrioux commented Dec 3, 2020

Hello,
My bad, small mixup. Thought we had concluded we would quote them.

Though, just tested with commit floraison/flor@465d4ed, on Ruby 2.3.8 and 2.6.6 and the issue remains when return is unquoted.

@jmettraux
Copy link
Member

OK, I'm reopening then. Thanks!

@jmettraux jmettraux mentioned this pull request Dec 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrioux @jmettraux