remove duplicate command (keep container aware version : support 2.3+)

Command/DownloadDatasetCommand.php

@@ -2,29 +2,25 @@
 namespace Laposte\DatanovaBundle\Command;
 
 use Laposte\DatanovaBundle\Service\Downloader;
-use Symfony\Component\Console\Command\Command;
+use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**
+ * Symfony 2.3+ DownloadDatasetCommand
+ *
  * @author Florian Ajir <[email protected]>
  */
-class DownloadDatasetCommand extends Command
+class DownloadDatasetCommand extends ContainerAwareCommand
 {
     /** @var Downloader $downloader */
     private $downloader;
 
     /**
-     * @param Downloader $downloader
+     * Command configuration
      */
-    public function __construct(Downloader $downloader)
-    {
-        $this->downloader = $downloader;
-        parent::__construct();
-    }
-
     protected function configure()
     {
         $this
@@ -59,6 +55,7 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        $this->downloader = $this->getContainer()->get('data_nova.service.downloader');
         $dataset = $input->getArgument('dataset');
         $format = strtolower($input->getArgument('format'));
         $query = $input->getArgument('q');

README.md

@@ -99,4 +99,4 @@ Options:
   -f, --force-replace   If set, the command will replace local storage
 ```
 
-`Example: php app/console datanova:legacy:download:dataset laposte_hexasmal json -f`
+`Example: php app/console datanova:download:dataset laposte_hexasmal json -f`

Resources/config/services.yml

@@ -29,13 +29,6 @@ services:
         calls:
             - ['setLogger', ['@?logger']]
 
-    data_nova.command.download.dataset:
-        class: Laposte\DatanovaBundle\Command\DownloadDatasetCommand
-        arguments:
-            - '@data_nova.service.downloader'
-        tags:
-            -  { name: console.command }
-
     data_nova.parser.csv:
         class: Laposte\DatanovaBundle\Parser\CsvParser
         arguments:

Resources/dataset/README.md

@@ -26,9 +26,3 @@ Options:
 Help:
  Download dataset records to use it locally
 ```
-
-### Legacy command (Symfony < 2.4)
-
-```
-datanova:legacy:download:dataset
-```