Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging overhaul #225

Merged
merged 14 commits into from
Dec 9, 2021
Merged

Logging overhaul #225

merged 14 commits into from
Dec 9, 2021

Conversation

latenssi
Copy link
Member

@latenssi latenssi commented Dec 2, 2021

No description provided.

@latenssi latenssi changed the base branch from main to latenssi/maintenance-flag December 2, 2021 14:06
@latenssi latenssi linked an issue Dec 2, 2021 that may be closed by this pull request
Overhaul logging #223
Closed
@latenssi latenssi marked this pull request as ready for review December 8, 2021 11:41
Base automatically changed from latenssi/maintenance-flag to main December 8, 2021 12:23
nanuuki
nanuuki requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLOW_WALLET_LOG_LEVEL isn't documented; a mention of it in the README should suffice. Otherwise LGTM :)

chain_events/listener.go Show resolved Hide resolved
handlers/middleware.go Outdated Show resolved Hide resolved
@latenssi latenssi merged commit 70853bd into main Dec 9, 2021
@latenssi latenssi deleted the latenssi/logging-overhaul branch December 9, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanuuki nanuuki nanuuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul logging
2 participants
@latenssi @nanuuki