Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report every unique range in message parts #411

Closed
wants to merge 1 commit into from
Closed

Report every unique range in message parts #411

wants to merge 1 commit into from

Conversation

TexKiller
Copy link

Should resolve #39

@mroch
Copy link
Contributor

mroch commented Sep 19, 2021

thanks for this PR! however, we've removed the non-LSP integration that this was affecting.

also, I think that in the years since #39, Flow has greatly improved our error positioning such that it should always report the error at the call site, not at the definition, so we only want to show the error at the "primary" location, not at each of the reference locations. as far as I can tell, this is working as expected:

Screen Shot 2021-09-19 at 2 02 49 PM

@mroch mroch closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Red squiggly lines not shown for missing prop in JSX
3 participants