Change subtrace_len computation algo in FoldFSM #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to handle scripts like this
there was a temporary solution based on additional field called
total_subtrace_len
. This solution is needed because ofPar
andFold
decribe their subtree lens differently with respect tonext
instruction:Par
includes states that next brings, whileFold
not.The new algo changes this scheme and does a convolution of a
Fold
subtrace_len
. Let's it on examples, imagine a fold on stream with 3 elements that have the same generation, in this case convolution will look like this:here a number before comma represents count of elements before next, and after the comma - after
For fold with 5 elements of two generations:
This algo allows us to get rid of
total_subtrace_len
and all code that supports it.Resolves #135.