Refactor join behaviour and par subtree completeness #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikevoronov
changed the title
ValeryAntopol
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
callsetssubtree_completeto false in join behaviourmatch/mismatch/folddon't touchsubtree_completein join behaviourpar's subtree could be completed (subtree_complete= true) even if it's finished with a error (Bug: par could treat a subtree completed if it finished with a error #180 was caused with this behaviour)After this PR:
call/match/mismatch/foldsetsubtree_completeto false in join behaviourparsets subtree complete to false if there's an errorResolves #180.