Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility not to forward _make_packet errors #187

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

vgavro
Copy link
Contributor

@vgavro vgavro commented Feb 15, 2022

if there is some error in FluentSender._make_packet - it's forwarded to fluent host instead of adding possibility to get local exception before forward. Added option for this forward_packet_error - which defaults to True for backward-compatibility.

Also EventTime creation (for nanoseconds precision) moved to _make_packet - just to more easily implement some custom logic for bulk sending..

@vgavro vgavro force-pushed the no_forward_make_packet_error branch from 786ddad to 0468c7d Compare February 15, 2022 19:13
@coveralls
Copy link

coveralls commented Feb 15, 2022

Coverage Status

Coverage decreased (-0.3%) to 99.726% when pulling 0468c7d on vgavro:no_forward_make_packet_error into ace80f4 on fluent:master.

@methane methane merged commit f3bc435 into fluent:master Feb 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants