Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recent multiarch build on DockerHub #203

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Dec 24, 2019

Also Dockerfiles are buildable by our laptop with Docker Desktop.

For laptop building:

For arm64 image

$ docker run --rm --privileged multiarch/qemu-user-static:register --reset
$ make DOCKERFILE=v1.8/arm64/debian VERSION=v1.8.0-debian-arm64-1.0

For armhf image

$ docker run --rm --privileged multiarch/qemu-user-static:register --reset
$ make DOCKERFILE=v1.8/armhf/debian VERSION=v1.8.0-debian-armhf-1.0

On DockerHub

My testing are succeeded:

NOTE: My testing uses testing branch for DockerHub building.

ref: docker/hub-feedback#1261

Dockerfile.template.erb Outdated Show resolved Hide resolved
Copy link
Member

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@cosmo0920
Copy link
Contributor Author

@repeatedly ?

@cosmo0920
Copy link
Contributor Author

Let's :shipit:!

@cosmo0920 cosmo0920 merged commit 68a3842 into fluent:master Dec 24, 2019
@cosmo0920 cosmo0920 deleted the armhf-and-arm64-images-build branch December 24, 2019 05:55
@cosmo0920
Copy link
Contributor Author

arm64 and armhf images are built successfully! 🎉
https://hub.docker.com/repository/docker/fluent/fluentd/builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants