Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

17-futures/countries/flags_asyncio.py fails to download flags #25

Open
cdm-work opened this issue Sep 13, 2018 · 1 comment
Open

17-futures/countries/flags_asyncio.py fails to download flags #25

cdm-work opened this issue Sep 13, 2018 · 1 comment

Comments

@cdm-work
Copy link

cdm-work commented Sep 13, 2018

When running with python 3.6.6, with aiohttp 3.3.2, the 'flags_asyncio.py' script outputs 20 pairs of lines similar to this:
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x10ecbfd68>
followed by 20 tracebacks similar to this:
Task exception was never retrieved
future: <Task finished coro=<download_one() done, defined at flags_asyncio.py:28> exception=TypeError("'_SessionRequestContextManager' object is not iterable",)>
Traceback (most recent call last):
File "flags_asyncio.py", line 30, in download_one
image = yield from get_flag(cc) # <7>
File "flags_asyncio.py", line 23, in get_flag
resp = yield from aiohttp.request('GET', url) # <4>
TypeError: '_SessionRequestContextManager' object is not iterable

cdm-work added a commit to cdm-work/example-code that referenced this issue Sep 20, 2018
The changes to 17-futures/countries/flags_asyncio.py allow it to work
with Python 3.6.6 and aiohttp 3.4.4.
@cdm-work
Copy link
Author

Pull request #26 would address this issue. Obviously it would be out of sync with the book contents, but it would actually work and produce a positive result.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant