Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge diagnose fluid scripts #2597

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhang-x-z
Copy link
Collaborator

Ⅰ. Describe what this PR does

Merge the following diagnose scripts into one scripts: diagnose-fluid.sh.

  • tools/diagnose-fluid-goosefs.sh
  • tools/diagnose-fluid-alluxio.sh
  • tools/diagnose-fluid-juicefs.sh
  • tools/diagnose-fluid-jindo.sh

Add an option -t or --type to specific which runtime to diagnose.

Ⅱ. Does this pull request fix one issue?

fixes #2364

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No test cases were added. Testing can be done manually.

Ⅳ. Describe how to verify it

Run diagnose-fluid.sh with optin -t alluxio, -t goosefs, -t juicefs and -t jindo and compare the result with the result output by original scripts.

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 15, 2023

Hi @zhang-x-z. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2597 (6869861) into master (ec70981) will not change coverage.
The diff coverage is n/a.

❗ Current head 6869861 differs from pull request most recent head ebbb27a. Consider uploading reports for the commit ebbb27a to get more accurate results

@@           Coverage Diff           @@
##           master    #2597   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files         368      368           
  Lines       21516    21516           
=======================================
  Hits        14542    14542           
  Misses       5267     5267           
  Partials     1707     1707           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURES] Merge diagnose scripts for different runtime into a single scipt
1 participant