-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alluxio): should use json tag instead of yaml tag #2773
fix(alluxio): should use json tag instead of yaml tag #2773
Conversation
Hi @weixiao-huang. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…s yaml to unmarshal, which only see json tag Signed-off-by: weixiao-huang <[email protected]>
dabae1d
to
0db9a49
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @weixiao-huang |
Codecov Report
@@ Coverage Diff @@
## master #2773 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 383 383
Lines 22289 22289
=======================================
Hits 14914 14914
Misses 5627 5627
Partials 1748 1748
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
Ⅰ. Describe what this PR does
Use json tag instaed of yaml tag since we use k8s yaml to unmarshal, which only use json tag
Ⅱ. Does this pull request fix one issue?
fixes #2772
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
See the related issue
Ⅴ. Special notes for reviews