Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alluxio): should use json tag instead of yaml tag #2773

Merged

Conversation

weixiao-huang
Copy link
Contributor

Ⅰ. Describe what this PR does

Use json tag instaed of yaml tag since we use k8s yaml to unmarshal, which only use json tag

Ⅱ. Does this pull request fix one issue?

fixes #2772

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

See the related issue

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 22, 2023

Hi @weixiao-huang. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…s yaml to unmarshal, which only see json tag

Signed-off-by: weixiao-huang <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cheyang cheyang changed the title fix(alluxio): should use json tag instaed of yaml tag fix(alluxio): should use json tag instead of yaml tag Mar 22, 2023
@cheyang
Copy link
Collaborator

cheyang commented Mar 22, 2023

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Mar 22, 2023

Thanks @weixiao-huang

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #2773 (dcaf9bc) into master (bcf844b) will not change coverage.
The diff coverage is n/a.

❗ Current head dcaf9bc differs from pull request most recent head 0db9a49. Consider uploading reports for the commit 0db9a49 to get more accurate results

@@           Coverage Diff           @@
##           master    #2773   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files         383      383           
  Lines       22289    22289           
=======================================
  Hits        14914    14914           
  Misses       5627     5627           
  Partials     1748     1748           
Impacted Files Coverage Δ
pkg/ddc/alluxio/types_selector.go 90.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TrafalgarZZZ
Copy link
Member

/lgtm

@cheyang cheyang merged commit 40d1f0f into fluid-cloudnative:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Could not set nodeAffinity in dataset
3 participants