Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to golang1.18.10 in eacruntime and webhook #2867

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wangshli
Copy link
Contributor

@wangshli wangshli commented Apr 3, 2023

Ⅰ. Describe what this PR does

update image to golang1.18.10 in eacruntime and webhook

Ⅱ. Does this pull request fix one issue?

fixes #2830

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 3, 2023

Hi @wangshli. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2867 (043e956) into master (d3de533) will not change coverage.
The diff coverage is n/a.

❗ Current head 043e956 differs from pull request most recent head 47d0a85. Consider uploading reports for the commit 47d0a85 to get more accurate results

@@           Coverage Diff           @@
##           master    #2867   +/-   ##
=======================================
  Coverage   65.58%   65.58%           
=======================================
  Files         396      396           
  Lines       22798    22798           
=======================================
  Hits        14951    14951           
  Misses       6098     6098           
  Partials     1749     1749           
Impacted Files Coverage Δ
pkg/ddc/alluxio/cache.go 75.67% <ø> (ø)
pkg/ddc/alluxio/dataset.go 69.33% <ø> (ø)
pkg/ddc/alluxio/label.go 100.00% <ø> (ø)
pkg/ddc/alluxio/shutdown.go 46.39% <ø> (ø)
pkg/ddc/alluxio/transform_init_users.go 100.00% <ø> (ø)
pkg/ddc/alluxio/transform_ufs.go 100.00% <ø> (ø)
pkg/ddc/alluxio/types.go 100.00% <ø> (ø)
pkg/ddc/alluxio/ufs.go 43.75% <ø> (ø)
pkg/ddc/goosefs/cache.go 69.23% <ø> (ø)
pkg/ddc/goosefs/worker.go 73.77% <ø> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: wangshulin <[email protected]>

add comments

Signed-off-by: wangshulin <[email protected]>
@cheyang
Copy link
Collaborator

cheyang commented Apr 6, 2023

/test fluid-e2e

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 6, 2023

@cheyang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fluid-e2e
  • /test fluid-e2e-080
  • /test fluid-e2e-nightly

In response to this:

/test fluid-e2e-night

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang
Copy link
Collaborator

cheyang commented Apr 6, 2023

/test fluid-e2e-nightly

@cheyang
Copy link
Collaborator

cheyang commented Apr 7, 2023

@wangshli Could you also update other related docker file? I think we'd better keep consistency.

@wangshli
Copy link
Contributor Author

wangshli commented Apr 7, 2023

@wangshli Could you also update other related docker file? I think we'd better keep consistency.

For all dockerfile with builder golang 1.18 ?

Signed-off-by: wangshulin <[email protected]>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin your Docker image by updating golang:1.18 to golang:1.18.10
2 participants