Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing 2023 to correct time 2020-s #4046

Merged

Conversation

DREAMINGtimezero
Copy link
Contributor

Ⅰ. Describe what this PR does

This PR changed context 2023 to correect time 2020 int the file ./pkg/ddc/alluxio/shutdown.go

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Allow edits by maintainers
Remember, contributions to this repository should follow its contributing guidelines, security policy, and code of conduct.
️no tests are needed.

👋

It looks like this is your first time opening a pull request in this project!

Be sure to review the contributing guidelines and code of conduct.

Reporting a security vulnerability?
Check out the project's security policy.

1 commit
1 file changed
1 contributor
Commits on May 6, 2024
changing 2023 to correct time 2020-s

@DREAMINGtimezero
DREAMINGtimezero committed 39 minutes ago
Showing with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion2
pkg/ddc/alluxio/shutdown.go
@@ -1,5 +1,5 @@
/*
Copyright 2023 The Fluid Author.
Copyright 2020 The Fluid Author.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Footer
© 2024 GitHub, Inc.
Footer navigation
Terms
Privacy
Security
Status
Docs
Contact
Manage cookies
Do not share my personal information
Comparing fluid-cloudnative:master...DREAMINGtimezero:dreamingtimezero-branch · fluid-cloudnative/fluid

Ⅳ. Describe how to verify it

you can check the file ./pkg/ddc/alluxio/shutdown.go to verify it

Ⅴ. Special notes for reviews

NONE

Copy link

fluid-e2e-bot bot commented May 6, 2024

Hi @DREAMINGtimezero. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiYuhang9527
Copy link
Contributor

please add "-s" when you use commande "git commit"

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

fluid-e2e-bot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ TrafalgarZZZ merged commit b5d1a83 into fluid-cloudnative:master May 30, 2024
3 checks passed
cheyang pushed a commit to Ametsuji-akiya/fluid that referenced this pull request Jul 16, 2024
* changing 2023 to correct time 2020-s

* changing 2020 to correct time 2023

Signed-off-by: dreamingtimezero <[email protected]>

* -schanging 2023 to correct time 2020

---------

Signed-off-by: dreamingtimezero <[email protected]>
Signed-off-by: cheyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants