Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated data operation interface #4130

Merged
merged 3 commits into from
May 29, 2024

Conversation

xliuqq
Copy link
Collaborator

@xliuqq xliuqq commented May 26, 2024

Ⅰ. Describe what this PR does

There are some methods and interface not used any more in the Engine/Implment, remove these to keep interface clear.

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
40.0% Duplication on New Code

See analysis details on SonarCloud

@cheyang
Copy link
Collaborator

cheyang commented May 27, 2024

/test fluid-e2e

@cheyang cheyang requested a review from TrafalgarZZZ May 27, 2024 08:50
@xliuqq
Copy link
Collaborator Author

xliuqq commented May 28, 2024

/retest

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 8601c7f into fluid-cloudnative:master May 29, 2024
9 checks passed
@xliuqq xliuqq deleted the refactor-dataop branch June 3, 2024 14:50
cheyang pushed a commit to Ametsuji-akiya/fluid that referenced this pull request Jul 16, 2024
…ve#4130)

* remove useless data operation methods

Signed-off-by: xliuqq <[email protected]>

* remove deprecated data operation interface

Signed-off-by: xliuqq <[email protected]>

* remove unused methods and constants

Signed-off-by: xliuqq <[email protected]>

---------

Signed-off-by: xliuqq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants