Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Add CacheworkerSet as an abstract interface for worker && Add AdvancedStatefulset Interface For Worker Pod Scale In #4294

Closed
wants to merge 29 commits into from

Conversation

zwbrealm
Copy link

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

fluid-e2e-bot bot commented Aug 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fluid-e2e-bot bot commented Aug 24, 2024

Hi @zwbrealm. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zwbrealm zwbrealm changed the title Create cacheworkerset.go [WIP]Create cacheworkerset.go Aug 24, 2024
@zwbrealm zwbrealm changed the title [WIP]Create cacheworkerset.go [WIP]Add CacheworkerSet as an abstract interface Aug 24, 2024
@zwbrealm zwbrealm changed the title [WIP]Add CacheworkerSet as an abstract interface [WIP]Add CacheworkerSet as an abstract interface for worker Aug 24, 2024
@zwbrealm zwbrealm marked this pull request as draft August 24, 2024 11:22
@zwbrealm
Copy link
Author

This code is still in progress; please ignore it for now.

@zwbrealm zwbrealm marked this pull request as ready for review August 24, 2024 11:45
@zwbrealm zwbrealm marked this pull request as draft August 24, 2024 11:46
@zwbrealm zwbrealm changed the title [WIP]Add CacheworkerSet as an abstract interface for worker [WIP]Add CacheworkerSet as an abstract interface for worker && Add AdvancedStatefulset Interface For Worker Pod Scale In Oct 5, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

@zwbrealm zwbrealm marked this pull request as ready for review October 15, 2024 12:22
@zwbrealm zwbrealm closed this Oct 20, 2024
@zwbrealm
Copy link
Author

代码思路错误,废弃这部分pr,重新写了一遍提在新的pr中

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant