Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Variables for simplify edits and enhance readability. #4313

Merged

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Sep 8, 2024

Ⅰ. Describe what this PR does

  1. Variable reorganization: Grouped related variables together for better clarity and easier maintenance.
  2. Enhanced architecture support.
  3. Standardized Docker build options.
  4. Consolidated build targets: Streamlined the definition of build targets for various controllers, reducing repetition in the Makefile.
  5. Improved multi-architecture support: Added Docker buildx targets to facilitate building for multiple architectures in a single command.
  6. Standardized naming conventions: Adopted more consistent naming for targets and variables throughout the Makefile.
  7. Enhanced modularity: Separated some functionalities into distinct targets, making the Makefile more modular and easier to extend.

Ⅱ. Does this pull request fix one issue?

Part of #4297

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@omerap12 omerap12 force-pushed the makefile_optimization_variables branch from 991c95d to cc2bbe2 Compare September 8, 2024 07:55
@omerap12
Copy link
Member Author

omerap12 commented Sep 8, 2024

@Syspretor, if valid Ill work on number 2 ( Phony Targets )

@Syspretor
Copy link
Collaborator

@omerap12 Thank you very much for this PR. The classification and organization of variable definitions is great, but there are some areas where we hope to improve. First of all, ensuring that all modules in the Makefile execute successfully is a priority in the optimization work for the Makefile. During my testing, I found some typos and syntax issues that broke this, such as the variable definition for DOCKER_PLATFORM on line 28, and a typo regarding the -f flag on line 231, among similar issues. So please try running the commands included in the Makefile to ensure they still work smoothly.

@omerap12
Copy link
Member Author

@omerap12 Thank you very much for this PR. The classification and organization of variable definitions is great, but there are some areas where we hope to improve. First of all, ensuring that all modules in the Makefile execute successfully is a priority in the optimization work for the Makefile. During my testing, I found some typos and syntax issues that broke this, such as the variable definition for DOCKER_PLATFORM on line 28, and a typo regarding the -f flag on line 231, among similar issues. So please try running the commands included in the Makefile to ensure they still work smoothly.

Got it. Ill test it myself then. Thanks for your review :)

@omerap12 omerap12 force-pushed the makefile_optimization_variables branch from cc2bbe2 to 35aec70 Compare September 17, 2024 11:46
Signed-off-by: trafalgarzzz <[email protected]>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.33%. Comparing base (22e808c) to head (ae8b975).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4313      +/-   ##
==========================================
- Coverage   62.90%   58.33%   -4.58%     
==========================================
  Files         483      563      +80     
  Lines       28570    31277    +2707     
==========================================
+ Hits        17972    18245     +273     
- Misses       8393    10785    +2392     
- Partials     2205     2247      +42     
Flag Coverage Δ
58.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 26, 2024

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omerap12 I made some minor changes to make Github Actions work with the latest Makefile. The PR LGTM, thanks for making it much more clear.
/lgtm

@omerap12
Copy link
Member Author

@omerap12 I made some minor changes to make Github Actions work with the latest Makefile. The PR LGTM, thanks for making it much more clear. /lgtm

No worries, I’m planning to enhance it further :)

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit f7e350e into fluid-cloudnative:master Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants