Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename :js? true opt #376

Closed
cap10morgan opened this issue Feb 9, 2023 · 1 comment · Fixed by #375
Closed

Rename :js? true opt #376

cap10morgan opened this issue Feb 9, 2023 · 1 comment · Fixed by #375
Assignees
@cap10morgan
Labels
enhancement New feature or request requires doc updates
Milestone
3.0.0-alpha1

Comments

@cap10morgan
Copy link
Contributor

cap10morgan commented Feb 9, 2023 •
edited
Loading

Rename the :js? true opt to something more generic like :context-type :string. It is useful outside of JS usage, so it was a little misleading.
@cap10morgan
Copy link
Contributor Author

I'm cheating by creating this issue after the work got done. I did indeed rename it to :context-type :string. And you can explicitly ask for the default with :context-type :keyword.

@cap10morgan cap10morgan self-assigned this Feb 9, 2023
@cap10morgan cap10morgan added this to the 3.0.0-alpha1 milestone Feb 9, 2023
@cap10morgan cap10morgan linked a pull request Feb 9, 2023 that will close this issue
Rename js? opt -> :context-type [:string|:keyword] #375
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cap10morgan cap10morgan

Labels
enhancement New feature or request requires doc updates
Projects
None yet
Milestone
3.0.0-alpha1
Development

Successfully merging a pull request may close this issue.

Rename js? opt -> :context-type [:string|:keyword] fluree/db
1 participant
@cap10morgan