Rename js? opt -> :context-type [:string|:keyword] #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...also accepts :contextType for our JS friends
dpetran
approved these changes
Feb 9, 2023
|
This is a great improvement. Any other repos that need to be updated for this? |
I think fluree/http-api-gateway#19 is it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
:js? trueopt to:context-type :stringor"contextType": "string"for JSON. Also accepts:context-type :keywordwhich is still the default.This is just my proposal for a better name for the
js?opt. I'm happy to tweak the details.Oh, also snuck in 15b4a49 which I have had lying around in local working dirs forever and just want to finally get onto main. Let me know if you'd rather I split it out.