Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-1431: fix/unresolve nodes #195

Merged
merged 3 commits into from
Sep 2, 2022
Merged

FC-1431: fix/unresolve nodes #195

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcd4ff
add fn unresolve to remove cached flakes/children from nodes
zonotope Aug 31, 2022
360c7de
fix/add docstrings for resolve/unresolve
zonotope Sep 1, 2022
7518dee
unresolve child nodes before adding them to branches
zonotope Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fluree/db/index.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@

(defn child-entry
[{:keys [first] :as node}]
[first node])
(let [child-node (unresolve node)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to try to summarize my understanding of this to make sure I've got it correct:

child-entry takes a node and returns a tuple of the the first flake it addresses and the node itself. This change unresolves the node itself so it won't carry around the :children or :flakes references.

Is it to reduce the size of the node we need to pass around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This code is mainly used when the database is re-indexed. In that case, the entire index tree is loaded into memory, node by node, and rebalanced. Without this change, the result of the indexing process would hold the all the data from an index in memory, thus eliminating the gains from processing the index node by node instead of all at once. This change instead keeps a pointer to the top level child nodes on disk, and those child nodes keep pointers to their children, and so on. The whole benefit of this change is memory efficiency for the indexing process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the explanation, that makes perfect sense.

[first child-node]))

(defn child-map
"Returns avl sorted map whose keys are the first flakes of the index node
Expand Down