Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the case where parse* query-map has parse-json? instead of parseJSON #206

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Fix the case where parse* query-map has parse-json? instead of parseJSON #206

merged 2 commits into from
Oct 12, 2022

Conversation

cap10morgan
Copy link
Contributor

Sometimes the query-map coming into the parse* fn has a :parseJSON opt and sometimes it has :parse-json?. This handles both cases.

Would this issue go away if we just used :parseJSON internally too? Yes. Is not doing that a hill I'm willing to die on? Also yes. ;)

@cap10morgan cap10morgan requested a review from a team October 4, 2022 15:52
@cap10morgan cap10morgan mentioned this pull request Oct 4, 2022
Merged
zonotope
zonotope approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀 ⛰️

@cap10morgan cap10morgan merged commit b9c6755 into main Oct 12, 2022
@cap10morgan cap10morgan deleted the fix/deserialize-json-preds branch October 12, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonotope zonotope zonotope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cap10morgan @zonotope