Encapsulate Index #218
Merged
Encapsulate Index #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This watch was just a placeholder for future watching functionality, but it's not currently used. The watching functionality itself also encourages propogating mutable state and complects the indexing and ledger update operation. I think we should instead use explicit function calls with persistent values instead of mutable state to implement this functionality when we eventually need it.
This allows us to run only the integration tests with: ``` clojure -M:cljtest --focus-meta :integration ```
dpetran
approved these changes
Nov 3, 2022
Thanks! This is still a draft though. There's more to come. |
|
Haha, whoops. I wondered that removing the listeners was the only change you made to the ledger... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch attempts to remove some of our reliance on mutable state to initialize and manage ledgers, indexers, and databases.