Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/union query #261

Merged
merged 7 commits into from
Nov 18, 2022
Merged

Feature/union query #261

merged 7 commits into from
Nov 18, 2022

Conversation

bplatz
Copy link
Contributor

@bplatz bplatz commented Nov 17, 2022

This addresses issue #250 and adds support for union clauses within where statements.

The core cases are supported here, but there could usages of union statements that are not covered here and may require some revisiting.

See new test namespace for examples.

@bplatz bplatz requested a review from a team November 17, 2022 14:56
Copy link
Contributor

@cap10morgan cap10morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@cap10morgan
Copy link
Contributor

@bplatz Just FYI: If you say something like "Fixes #250" or "closes #250" in your PR it will automatically close the issue when the PR is merged. I'm not sure what all the supported variants are, but I know those two work at least.

@cap10morgan
Copy link
Contributor

Getting a strange error (No such var: union) from the linter in CI. Not sure if that's something it should be told to ignore or an actual issue.

@cap10morgan
Copy link
Contributor

Looks like this line is calling a fn that doesn't exist in the aliased namespace? I think that's what the linter is complaining about.

@mpoffald
Copy link
Contributor

@cap10morgan The analytical ns was unused and got removed in #259, this branch just doesn't have that change. So we can safely ignore that I think

@bplatz bplatz merged commit 0080232 into main Nov 18, 2022
@bplatz bplatz deleted the feature/union-query branch November 18, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants