Make stage & commit! args more explicit #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
stage
to only take db's as args (still w/ optional opts arg) b/c under the hood it's a fn of db's.commit!
to only take a ledger and a db as args (i.e. it no longer supports just a ledger or a just a db; still w/ optional opts arg) b/c under the hood it's a fn of ledgers and db's.The second commit updates all the tests for the new signatures.
Fixes #337